Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

feat(codesandbox): add examples #908

Merged
merged 29 commits into from
Dec 15, 2021
Merged

feat(codesandbox): add examples #908

merged 29 commits into from
Dec 15, 2021

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#754

Description

Add codesandbox examples for each component.

Updated small issues with cdn example.

Changelog

New

  • component folder containing a codesandbox folder for each component

Changed

  • text for tag from "This is not a tag" to "This is a tag"

Removed

  • {{removed thing}}

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner December 13, 2021 16:50
@ariellalgilmore ariellalgilmore requested review from emyarod, IgnacioBecerra and JBrandwine and removed request for a team December 13, 2021 16:50
github-actions[bot]
github-actions bot reviewed Dec 13, 2021
View reviewed changes
src/components/tag/tag-story-angular.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story-angular.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story-angular.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story-angular.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story-angular.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story.ts Outdated Show resolved Hide resolved
src/components/tag/tag-story.ts Outdated Show resolved Hide resolved
ariellalgilmore and others added 22 commits December 13, 2021 09:08
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
16274e9 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
8f3c338 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
03b03e4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
d25631f 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
8f2b8cd 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
2797441 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
7320e9a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
d43e426 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
c5a8140 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
d7b2ae2 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-angular.ts
820e41f 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-react.tsx
8a350db 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
d5b8118 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
ead76bb 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-vue.ts
e537426 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-vue.ts
feb82c4 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story-vue.ts
7b091ec 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
ddc13bc 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
491cd42 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
6e001c0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
ccc3fe6 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ariellalgilmore @github-actions
Update src/components/tag/tag-story.ts
d29c72f 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/908/index.html

Built with commit: e290fce5726bce33039f738a80108732ebb1b65e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/908/index.html

Built with commit: e290fce5726bce33039f738a80108732ebb1b65e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/908/index.html

Built with commit: e290fce5726bce33039f738a80108732ebb1b65e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/908/index.html

Built with commit: e290fce5726bce33039f738a80108732ebb1b65e

emyarod
emyarod approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just have a couple of questions:

should we update basic/.gitignore to also ignore the components directory? that way they won't show up in the existing CSB example if we still want to keep that example https://codesandbox.io/s/github/carbon-design-system/carbon-web-components/tree/feat/codesandbox/examples/codesandbox/basic

also should we set a width of 300px on the container around each component like the current basic CSB example? https://github.com/carbon-design-system/carbon-web-components/blob/feat/codesandbox/examples/codesandbox/basic/index.html#L19-L21

other than that looks good to me!

@emyarod emyarod mentioned this pull request Dec 14, 2021
Closed
@ariellalgilmore
Copy link
Member Author

just have a couple of questions:

should we update basic/.gitignore to also ignore the components directory? that way they won't show up in the existing CSB example if we still want to keep that example https://codesandbox.io/s/github/carbon-design-system/carbon-web-components/tree/feat/codesandbox/examples/codesandbox/basic

yeah good catch! will check with team if we still want to keep that example and if so then ignore the components directory

also should we set a width of 300px on the container around each component like the current basic CSB example? https://github.com/carbon-design-system/carbon-web-components/blob/feat/codesandbox/examples/codesandbox/basic/index.html#L19-L21

I wasn't sure about that either. I was looking at Carbon's react codesandbox and they didn't set the width. I'll check with our team as well on that!

other than that looks good to me!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 15, 2021
@kodiakhq kodiakhq bot merged commit 80263bd into master Dec 15, 2021
@kodiakhq kodiakhq bot deleted the feat/codesandbox branch December 15, 2021 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@emyarod emyarod emyarod approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@JBrandwine JBrandwine Awaiting requested review from JBrandwine JBrandwine was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @emyarod @jeffchew